impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3654: Parquet stats filtering for IN predicate
Date Fri, 05 May 2017 23:17:54 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-3654: Parquet stats filtering for IN predicate
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/6810/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 379:     for (int i = 1; i < children.size(); i++) {
> ++i
Done


Line 383:       if (!(child instanceof LiteralExpr)) return;
> isLiteral() is more readable
Done


Line 384:       LiteralExpr literal_child = (LiteralExpr) child;
> Java style :) literalChild
Done


Line 394:     BinaryPredicate min_bound = new BinaryPredicate(BinaryPredicate.Operator.GE,
> minBound, maxBound
Done


http://gerrit.cloudera.org:8080/#/c/6810/1/testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test
File testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test:

Line 29: # Test a variety of types
> Add one query with the negative cases:
Done


http://gerrit.cloudera.org:8080/#/c/6810/1/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 300: # Verify NULL prevents using min/max
> Should be a planner test instead, so we can see that no min/max predicate i
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a88963a7206f40a867e49eceeaf03fdd4f71997
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message