impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Date Fri, 05 May 2017 10:42:16 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4166: Add SORT BY sql clause
......................................................................


Patch Set 17:

(3 comments)

Thanks for the review. Please see PS19 and my inline comments.

http://gerrit.cloudera.org:8080/#/c/6495/17/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:

PS17, Line 183: // ALTER TABLE SET is not supported on HBase tables altogether.
              :     Preconditions.checkState(!(table instanceof HBaseTable));
> Sorry, I was misled by the comment above it and by the fact that I didn't s
For the SORT BY, there's a check in AlterTableSortByColumnsStmt::analyze().

For ALTER TABLE SET, there's a check in AlterTableSetStmt::analyze().

I added a reference to that in the comment. Please let me know if I should describe it in
more detail in the comment.


http://gerrit.cloudera.org:8080/#/c/6495/18/testdata/workloads/functional-planner/queries/PlannerTest/ddl.test
File testdata/workloads/functional-planner/queries/PlannerTest/ddl.test:

PS18, Line 183: # CTAS with partitions and sort by columns
> If you don't have one already, can you add a test for a partitioned table w
I'm not sure I'm following here. sort by() cannot have an empty column list. It's a parser
error and tested in ParserTest.java:2365. Do you have a particular corner case in mind that
you'd like to test here?

That being said, I'm not sure your second suggestion would work. I added a test to the bottom
of alter-table.test to check that changing the sort by columns works on a partitioned table.


http://gerrit.cloudera.org:8080/#/c/6495/18/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test
File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test:

PS18, Line 327: 
> Thanks for adding this test. Can you also add another one in which theres i
I added a test. The columns get concatenated as described in the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/6495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75
Gerrit-PatchSet: 17
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message