impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5273: Replace StringCompare with glibc memcmp
Date Thu, 04 May 2017 23:18:45 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5273: Replace StringCompare with glibc memcmp
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG
Commit Message:

PS1, Line 17:  (repeat("a", 2048));
> Where can I find information about the nightly perf test suite?
Alternatively, you could run any other benchmark that gives more comprehensive coverage of
the impala code paths. Or explain why the query you've run does give us all the coverage we
need.


http://gerrit.cloudera.org:8080/#/c/6768/2/be/src/runtime/string-value.inline.h
File be/src/runtime/string-value.inline.h:

PS2, Line 40: memcmp
why not strncmp()? oh, I guess memcmp() is faster since it doesn't need to check for null
termination (and we don't need that on this path)?


-- 
To view, visit http://gerrit.cloudera.org:8080/6768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message