impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause
Date Thu, 04 May 2017 22:02:03 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4166: Add SORT BY sql clause

Patch Set 17:

Commit Message:

PS17, Line 30: SORT BY columns supersede the sortby() hint, which we will remove in a
             : subsequent change (IMPALA-5144).
Mention what happens if both are used (e.g. union the columns or something else)
File fe/src/main/java/org/apache/impala/analysis/

PS17, Line 152: Returns a list of positions of
              :    * the sort by columns within the table's list of columns
This function doesn't return anything.

PS17, Line 183: // ALTER TABLE SET is not supported on HBase tables altogether.
              :     Preconditions.checkState(!(table instanceof HBaseTable));
This check doesn't belong here. Maybe move it to the analyze() function?
File fe/src/main/java/org/apache/impala/analysis/

PS17, Line 61: HashMap
nit: Map

PS17, Line 87: a
nit: an
File fe/src/main/java/org/apache/impala/analysis/

PS17, Line 138:  
Mention what happens if both are used (i.e. and sortby() hint).
File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test:

PS17, Line 1: #
Add one or more tests where the sortby hint is used in conjunction with sort by clause, if
you don't already have one.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75
Gerrit-PatchSet: 17
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message