impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Experiment: glibc strncmp/memcmp appears much faster than SSE4.2
Date Tue, 02 May 2017 21:05:24 GMT
Jim Apple has posted comments on this change.

Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG
Commit Message:

PS1, Line 17: memcmp is sse4.1-based
> Oops, yeah cmp.
OK. Can you be specific about the benchmarks you'd like to see run, to avoid to many iterations
of this patch set, including any node configuration or scale factor or file type restrictions
you will require?

As a heads-up: I am not in a position to spend a lot of time setting up benchmarks that don't
work out-of-the box with Apache Impala on a single node, so I may have to pass this off to
someone else or just submit this change to the benchmark and let somebody else finish it if
what you need requires more time than I have.


-- 
To view, visit http://gerrit.cloudera.org:8080/6768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message