impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5262: test analytic order by random fails with assert
Date Mon, 01 May 2017 23:47:39 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5262: test_analytic_order_by_random fails with assert
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6775/1/tests/query_test/test_sort.py
File tests/query_test/test_sort.py:

Line 189
Do we have any end-to-end tests that exercise non-deterministic exprs in an analytic sort?
If not, I suggest we try to fix this test instead.

I know there are PlannerTests, but having at least one end-to-end tests seems prudent.


-- 
To view, visit http://gerrit.cloudera.org:8080/6775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba8154c2b6a8d508916d85391b95885ef915a9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message