impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5162,IMPALA-5163: stress test support on secure clusters
Date Mon, 01 May 2017 21:12:38 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5162,IMPALA-5163: stress test support on secure clusters
......................................................................


Patch Set 1:

(2 comments)

Changes look reasonable, but I'm not super familiar with this code.

http://gerrit.cloudera.org:8080/#/c/6763/1/tests/comparison/cluster.py
File tests/comparison/cluster.py:

Line 364:                                               "0.0.0.0:50070")
Independent question:
Does it even make sense to plug in default values here?
Seems like a misconfiguration might be hard to debug if we plug in default values, instead
of throwing an error.


Line 412:           local_shell(pip_path + " install pykerberos==1.1.14 requests-kerberos==0.11.0",
Not your change, but this flow strikes me as odd. We have packages+versions baked into the
code here. What's the benefit of doing this lazy install+import as opposed to requiring these
to be installed up-front?


-- 
To view, visit http://gerrit.cloudera.org:8080/6763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0daad57bb8ceeb5071b75125f11c1997ed7e0179
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message