impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5266 Impala ABM / LZCNT support
Date Mon, 01 May 2017 20:06:18 GMT
Zach Amsden has uploaded a new patch set (#5).

Change subject: IMPALA-5266 Impala ABM / LZCNT support
......................................................................

IMPALA-5266 Impala ABM / LZCNT support

I recently added some code that wants to do upwards power of 2
calculation.  Turns out this can be done much more quickly in
hardware.  It isn't on a perf critical code path yet but
still seems like a decent idea.

PopcountNoHw was absolutely atrocious as it contains a totally
unpredictable loop that can be computed much more efficiently,
so I fixed that as well.

Testing: Added a perf test to verify this is faster (it is)
and updated the bit-util-test to add better test coverage.

Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2
---
M be/src/benchmarks/CMakeLists.txt
A be/src/benchmarks/bit-intrinsics-benchmark.cc
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
M be/src/util/fixed-size-hash-table.h
M be/src/util/sse-util.h
8 files changed, 287 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/5821/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f6a465ab4a9ee4f582847f8e211a779bdede3d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message