Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6E0EA200C64 for ; Fri, 28 Apr 2017 19:35:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6CAC8160BA3; Fri, 28 Apr 2017 17:35:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B40CA160B95 for ; Fri, 28 Apr 2017 19:35:14 +0200 (CEST) Received: (qmail 18761 invoked by uid 500); 28 Apr 2017 17:35:12 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 18750 invoked by uid 99); 28 Apr 2017 17:35:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 17:35:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F1EE21B10A2 for ; Fri, 28 Apr 2017 17:35:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UnoU4fgpmouD for ; Fri, 28 Apr 2017 17:35:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0C0715FC4A for ; Fri, 28 Apr 2017 17:35:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3SHZ9GP007327; Fri, 28 Apr 2017 17:35:09 GMT Date: Fri, 28 Apr 2017 17:35:09 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5246=3A_UDF=27s_Close=28=29_should_handle_Expr=27s_preparation_failure=0A?= X-Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c X-Gerrit-ChangeURL: X-Gerrit-Commit: c7d4f2987dd8b50e3aef18356ced38c3da08e52f MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Apr 2017 17:35:15 -0000 Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6757 Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure ...................................................................... IMPALA-5246: UDF's Close() should handle Expr's preparation failure UDF may fail to initialize due low memory limit or other reasons In which case, its Prepare() function may not have been called and its thread local state may not be initialized. The Close() functions of some of the built-in and test-udf made the wrong assumption that the thread local states are always initialized. This may lead to de-referencing null pointer in Close(). This change fixes this issue by checking the thread local state is not null and returns early if so. Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c --- M be/src/exprs/case-expr.cc M be/src/exprs/math-functions-ir.cc M be/src/exprs/string-functions-ir.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/utility-functions.cc M be/src/testutil/test-udfs.cc 6 files changed, 17 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/6757/1 -- To view, visit http://gerrit.cloudera.org:8080/6757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho