Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 245BC200C72 for ; Fri, 28 Apr 2017 01:52:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2168F160BB5; Thu, 27 Apr 2017 23:52:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6910C160BA7 for ; Fri, 28 Apr 2017 01:52:02 +0200 (CEST) Received: (qmail 25120 invoked by uid 500); 27 Apr 2017 23:52:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 25099 invoked by uid 99); 27 Apr 2017 23:52:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 23:52:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ED4D01858C8 for ; Thu, 27 Apr 2017 23:52:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id x1xQJNSVE0Cl for ; Thu, 27 Apr 2017 23:51:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 269C95FC8C for ; Thu, 27 Apr 2017 23:51:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3RNpuuv030808; Thu, 27 Apr 2017 23:51:56 GMT Date: Thu, 27 Apr 2017 23:51:56 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Marcel=27s_review_2=2E0=0A?= X-Gerrit-Change-Id: Ieb788780ad570b84d5660a6f6ca0c9c24f3eb016 X-Gerrit-ChangeURL: X-Gerrit-Commit: cc50287230d92855c1c7a9edc9efda035415988a MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 27 Apr 2017 23:52:03 -0000 Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6753 Change subject: Marcel's review 2.0 ...................................................................... Marcel's review 2.0 Change-Id: Ieb788780ad570b84d5660a6f6ca0c9c24f3eb016 --- M be/src/exec/kudu-util.cc M be/src/exec/kudu-util.h M be/src/exprs/kudu-partition-expr.cc M be/src/exprs/kudu-partition-expr.h M be/src/runtime/data-stream-sender.cc M be/src/runtime/data-stream-sender.h M common/thrift/Exprs.thrift M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java M fe/src/main/java/org/apache/impala/planner/DataPartition.java M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/kudu-upsert.test M testdata/workloads/functional-planner/queries/PlannerTest/kudu.test 13 files changed, 109 insertions(+), 121 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/6753/1 -- To view, visit http://gerrit.cloudera.org:8080/6753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb788780ad570b84d5660a6f6ca0c9c24f3eb016 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall