Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA66E200C5A for ; Tue, 18 Apr 2017 22:13:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C8B26160BA1; Tue, 18 Apr 2017 20:13:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1BBCF160B87 for ; Tue, 18 Apr 2017 22:13:19 +0200 (CEST) Received: (qmail 88403 invoked by uid 500); 18 Apr 2017 20:13:19 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 88390 invoked by uid 99); 18 Apr 2017 20:13:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 20:13:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AF8DAC0027 for ; Tue, 18 Apr 2017 20:13:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1ysgb3zlU4JC for ; Tue, 18 Apr 2017 20:13:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4344A5F4EE for ; Tue, 18 Apr 2017 20:13:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3IKDFpp000866; Tue, 18 Apr 2017 20:13:15 GMT Date: Tue, 18 Apr 2017 20:13:15 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5222=3A_don=27t_call_Bits=3A=3ALog2*=28=29_functions=0A?= X-Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c X-Gerrit-ChangeURL: X-Gerrit-Commit: a60485916d43fdf63e5f7571abb5be7315b63eb3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 20:13:21 -0000 Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6675 Change subject: IMPALA-5222: don't call Bits::Log2*() functions ...................................................................... IMPALA-5222: don't call Bits::Log2*() functions Some of gutil's functions are fairly inefficient. We accidentally regressed this when switching to the new Bits::, and some of the BufferPool code that was in flight didn't switch over. This commit switches to calling BitUtil::Log2*() everywhere and makes sure that those functions are all implemented in an efficient way. Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c --- M be/src/exec/parquet-column-readers.cc M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/disk-io-mgr.cc M be/src/runtime/free-pool.h M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/tmp-file-mgr.cc M be/src/util/bit-util-test.cc M be/src/util/bit-util.h M be/src/util/dict-encoding.h M be/src/util/hdr-histogram.cc 11 files changed, 45 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/6675/1 -- To view, visit http://gerrit.cloudera.org:8080/6675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong