Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 226AC200C6B for ; Tue, 18 Apr 2017 06:49:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 20E14160BAE; Tue, 18 Apr 2017 04:49:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6934F160BAB for ; Tue, 18 Apr 2017 06:49:24 +0200 (CEST) Received: (qmail 9296 invoked by uid 500); 18 Apr 2017 04:49:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 9285 invoked by uid 99); 18 Apr 2017 04:49:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 04:49:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EA66EC0F8E for ; Tue, 18 Apr 2017 04:49:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xW3reBUBPvef for ; Tue, 18 Apr 2017 04:49:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7D8925FD6D for ; Tue, 18 Apr 2017 04:49:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3I4nJsN019360; Tue, 18 Apr 2017 04:49:19 GMT Date: Tue, 18 Apr 2017 04:49:19 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4548=3A_BlockingJoinNode_should_wait_for_async_build_thread=0A?= X-Gerrit-Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342 X-Gerrit-ChangeURL: X-Gerrit-Commit: d720e08be1f309cbeadfc5723d1051e6f7907ba5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 04:49:25 -0000 Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6664 Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread ...................................................................... IMPALA-4548: BlockingJoinNode should wait for async build thread This is a minor clean up for the handling of the async build thread in BlockingJoinNode. In particular, the main thread used to block on the promise passed to the async build thread and won't proceed until the status is set. Async build thread relies on the fragile assumption that no other states (e.g. runtime state object) will be accessed once the promise is set. This has proven to be fragile with the use-after-free bug in IMPALA-4532. This change removes the reliance on fragile assumption by making the main thread join the async build thread before proceeding. Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342 --- M be/src/exec/blocking-join-node.cc M be/src/exec/blocking-join-node.h 2 files changed, 21 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6664/1 -- To view, visit http://gerrit.cloudera.org:8080/6664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho