Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4E481200C6B for ; Tue, 18 Apr 2017 04:08:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4CE31160BAE; Tue, 18 Apr 2017 02:08:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 947D3160BAB for ; Tue, 18 Apr 2017 04:08:37 +0200 (CEST) Received: (qmail 92580 invoked by uid 500); 18 Apr 2017 02:08:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92569 invoked by uid 99); 18 Apr 2017 02:08:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 02:08:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 35C77C0B41 for ; Tue, 18 Apr 2017 02:08:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id p4TPgkl4vUAn for ; Tue, 18 Apr 2017 02:08:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C181860D28 for ; Tue, 18 Apr 2017 02:08:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3I28WWv017035; Tue, 18 Apr 2017 02:08:32 GMT Date: Tue, 18 Apr 2017 02:08:32 +0000 From: "anujphadke (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: anujphadke Message-ID: Reply-To: aphadke@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5145_=3A_Do_not_constant_fold__null_in_CastExprs=0A?= X-Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93b0ea2233e6fbff00f34b9960fbe4f48bd50507 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 02:08:38 -0000 anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6663 Change subject: IMPALA-5145 : Do not constant fold null in CastExprs ...................................................................... IMPALA-5145 : Do not constant fold null in CastExprs Constant folding null values in CastExprs cuases CTAS statements to fail. This regresses with the behavior observed before constant folding changes were introduced. This change does not constant fold null in CastExprs. Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 --- M fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java M testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/6663/1 -- To view, visit http://gerrit.cloudera.org:8080/6663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke