Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6FF2200C64 for ; Fri, 28 Apr 2017 23:42:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B40A3160B95; Fri, 28 Apr 2017 21:42:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 079CD160BA3 for ; Fri, 28 Apr 2017 23:42:41 +0200 (CEST) Received: (qmail 46593 invoked by uid 500); 28 Apr 2017 21:42:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 46582 invoked by uid 99); 28 Apr 2017 21:42:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 21:42:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9B9EAC031B for ; Fri, 28 Apr 2017 21:42:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ETC7JzbwdauV for ; Fri, 28 Apr 2017 21:42:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 505D15FBBB for ; Fri, 28 Apr 2017 21:42:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3SLgcZ3017531; Fri, 28 Apr 2017 21:42:38 GMT Message-Id: <201704282142.v3SLgcZ3017531@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Apr 2017 21:42:38 +0000 From: "Attila Jeges (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Reply-To: attilaj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5261=3A_Heap_use-after-free_in_HdfsSequenceTableWriter=0A?= X-Gerrit-Change-Id: Id339247f892710529d8ad56dd1e98eadbf32900b X-Gerrit-ChangeURL: X-Gerrit-Commit: 9e08bc88f24e1a33576b66d9424f29c9382e5400 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Apr 2017 21:42:42 -0000 Attila Jeges has posted comments on this change. Change subject: IMPALA-5261: Heap use-after-free in HdfsSequenceTableWriter ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > I assumed you have verified the fix with ASAN build, right ? Yes, added testing details to the commit message. http://gerrit.cloudera.org:8080/#/c/6762/1/be/src/exec/hdfs-sequence-table-writer.cc File be/src/exec/hdfs-sequence-table-writer.cc: Line 306: value_length = text.size(); > DCHECK_EQ(value_length, row_buf_.Size()); Done -- To view, visit http://gerrit.cloudera.org:8080/6762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id339247f892710529d8ad56dd1e98eadbf32900b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes