Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 97326200C64 for ; Fri, 28 Apr 2017 23:15:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 95B70160BA3; Fri, 28 Apr 2017 21:15:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DC7EA160B95 for ; Fri, 28 Apr 2017 23:15:53 +0200 (CEST) Received: (qmail 12832 invoked by uid 500); 28 Apr 2017 21:15:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 12821 invoked by uid 99); 28 Apr 2017 21:15:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 21:15:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7D2DCC0245 for ; Fri, 28 Apr 2017 21:15:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id h4icQ3G4gMxN for ; Fri, 28 Apr 2017 21:15:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4D6AD5F297 for ; Fri, 28 Apr 2017 21:15:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3SLFnR2015386; Fri, 28 Apr 2017 21:15:49 GMT Message-Id: <201704282115.v3SLFnR2015386@ip-10-146-233-104.ec2.internal> Date: Fri, 28 Apr 2017 21:15:49 +0000 From: "Michael Ho (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5252=3A_Fix_crash_in_HiveUdfCall=3A=3AGetStringVal=28=29_when_mem_limit_exceeded=0A?= X-Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6 X-Gerrit-ChangeURL: X-Gerrit-Commit: c9617748a9c1e999d99c715a56e9e1ebca9f0aeb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 28 Apr 2017 21:15:54 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6761/1//COMMIT_MSG Commit Message: PS1, Line 10: a few other places Thanks for doing it. Please feel free to ignore but there are a few places in the code which can be converted to using StringVal::CopyFrom() even though they have the check: AggregateFunctions::ReservoirSampleFinalize(), CastFunctions::CastToChar(), udf-builtins-ir.cc, ? -- To view, visit http://gerrit.cloudera.org:8080/6761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes