Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EB551200C60 for ; Mon, 24 Apr 2017 23:13:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E9F88160B99; Mon, 24 Apr 2017 21:13:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3C720160B93 for ; Mon, 24 Apr 2017 23:13:12 +0200 (CEST) Received: (qmail 54010 invoked by uid 500); 24 Apr 2017 21:13:11 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53995 invoked by uid 99); 24 Apr 2017 21:13:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Apr 2017 21:13:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CC130C13F1 for ; Mon, 24 Apr 2017 21:13:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id G6eH4O0k7OBw for ; Mon, 24 Apr 2017 21:13:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id ADCDB5FB7A for ; Mon, 24 Apr 2017 21:13:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3OLD6xh000729; Mon, 24 Apr 2017 21:13:06 GMT Message-Id: <201704242113.v3OLD6xh000729@ip-10-146-233-104.ec2.internal> Date: Mon, 24 Apr 2017 21:13:06 +0000 From: "Sailesh Mukil (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5253=3A_Use_appropriate_transport_for_StatestoreSubscriber=0A?= X-Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b X-Gerrit-ChangeURL: X-Gerrit-Commit: cc0e9d7ba4164ab515892329b3737c20f9850ac2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 24 Apr 2017 21:13:13 -0000 Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6720 to look at the new patch set (#3). Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber ...................................................................... IMPALA-5253: Use appropriate transport for StatestoreSubscriber This makes sure that the appropriate Thrift transport is used in the StatestoreSubscriber. This patch also adds a custom cluster test to improve our security testing. Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b --- M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore.cc M tests/custom_cluster/test_client_ssl.py 3 files changed, 47 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/6720/3 -- To view, visit http://gerrit.cloudera.org:8080/6720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Henry Robinson