Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8BD81200C5C for ; Thu, 20 Apr 2017 19:24:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8A871160B9F; Thu, 20 Apr 2017 17:24:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D2170160B90 for ; Thu, 20 Apr 2017 19:24:43 +0200 (CEST) Received: (qmail 90337 invoked by uid 500); 20 Apr 2017 17:24:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 90326 invoked by uid 99); 20 Apr 2017 17:24:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2017 17:24:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 605D9C69F7 for ; Thu, 20 Apr 2017 17:24:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id aZ-lO7fSlpPR for ; Thu, 20 Apr 2017 17:24:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7ED825FBA0 for ; Thu, 20 Apr 2017 17:24:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3KHOeAs017882; Thu, 20 Apr 2017 17:24:40 GMT Message-Id: <201704201724.v3KHOeAs017882@ip-10-146-233-104.ec2.internal> Date: Thu, 20 Apr 2017 17:24:40 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada , anujphadke , Matthew Jacobs Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5220=3A_memory_maintenance_cleanup=0A?= X-Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 X-Gerrit-ChangeURL: X-Gerrit-Commit: eb8c6692d2e4516269634053f842fe0a64cdb3f6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 20 Apr 2017 17:24:44 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6626/7/be/src/common/init.cc File be/src/common/init.cc: PS7, Line 137: whenever : // consumption is checked is that true? consumption() doesn't refresh it -- I think only mem-tracker itself refreshes it, but outside callers won't. -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes