Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C58AE200C70 for ; Thu, 20 Apr 2017 03:23:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C42DF160BAA; Thu, 20 Apr 2017 01:23:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 17CE5160B9C for ; Thu, 20 Apr 2017 03:23:43 +0200 (CEST) Received: (qmail 85980 invoked by uid 500); 20 Apr 2017 01:23:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85969 invoked by uid 99); 20 Apr 2017 01:23:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Apr 2017 01:23:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 77BF3C1F96 for ; Thu, 20 Apr 2017 01:23:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id aqiaamHACRLK for ; Thu, 20 Apr 2017 01:23:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9B7085FB2C for ; Thu, 20 Apr 2017 01:23:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3K1Necw009235; Thu, 20 Apr 2017 01:23:40 GMT Message-Id: <201704200123.v3K1Necw009235@ip-10-146-233-104.ec2.internal> Date: Thu, 20 Apr 2017 01:23:40 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5229=3A_huge_page-backed_buffers_with_TCMalloc=0A?= X-Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9d8f7140c124c7ade996b0ad3e38295b97dfe236 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 20 Apr 2017 01:23:45 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5229: huge page-backed buffers with TCMalloc ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6687/2/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: Line 50: // Free() assumes that aggressive decommit is enabled for TCMalloc. > I saw the comment in Free() but don't follow how that means aggressive deco I believe MADV_NOHUGEPAGE just prevents future merging into huge pages and can leave the memory backed by huge pages. Some people at least claim that madvise(DONTNEED) doesn't work if you call it part of a transparent huge pages: https://www.percona.com/blog/2014/07/23/why-tokudb-hates-transparent-hugepages/ -- To view, visit http://gerrit.cloudera.org:8080/6687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84b46a46efed9aee6af41b5f10bf3f4b15889b8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes