Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04C2E200C6A for ; Wed, 19 Apr 2017 19:57:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03425160B9C; Wed, 19 Apr 2017 17:57:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4AB31160B94 for ; Wed, 19 Apr 2017 19:57:30 +0200 (CEST) Received: (qmail 50256 invoked by uid 500); 19 Apr 2017 17:57:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50245 invoked by uid 99); 19 Apr 2017 17:57:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 17:57:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E63E6185E70 for ; Wed, 19 Apr 2017 17:57:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rX27u-9WUBS0 for ; Wed, 19 Apr 2017 17:57:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AEF995FE3B for ; Wed, 19 Apr 2017 17:57:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3JHvQC7023454; Wed, 19 Apr 2017 17:57:26 GMT Message-Id: <201704191757.v3JHvQC7023454@ip-10-146-233-104.ec2.internal> Date: Wed, 19 Apr 2017 17:57:26 +0000 From: "Joe McDonnell (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: joemcdonnell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Revert_=22Pass_build_type_to_Impala_LZO=2E=22=0A?= X-Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3e833fcad89413dfbdcd175c1b8d4d512700e4f7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 19 Apr 2017 17:57:31 -0000 Joe McDonnell has posted comments on this change. Change subject: Revert "Pass build type to Impala LZO." ...................................................................... Patch Set 3: (1 comment) Updated the change to pass DEBUG to LZO. My local tests show this working fine. http://gerrit.cloudera.org:8080/#/c/6686/1/CMakeLists.txt File CMakeLists.txt: Line 390: COMMAND $ENV{IMPALA_LZO}/build.sh DEBUG ${CMAKE_SOURCE_DIR} > Joe is going to try this and post a new patch. Switching to passing DEBUG works on my setup. -- To view, visit http://gerrit.cloudera.org:8080/6686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15f0b383ef29d8eecccb69e9adde76386c7cdac6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-HasComments: Yes