Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 18611200C68 for ; Wed, 19 Apr 2017 00:02:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 16DAB160BAC; Tue, 18 Apr 2017 22:02:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5BD4C160BA1 for ; Wed, 19 Apr 2017 00:02:48 +0200 (CEST) Received: (qmail 50922 invoked by uid 500); 18 Apr 2017 22:02:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50911 invoked by uid 99); 18 Apr 2017 22:02:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 22:02:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EA5E7D2B2A for ; Tue, 18 Apr 2017 22:02:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KYHcHdsAmSU6 for ; Tue, 18 Apr 2017 22:02:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F3E765F405 for ; Tue, 18 Apr 2017 22:02:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3IM2g62006222; Tue, 18 Apr 2017 22:02:42 GMT Message-Id: <201704182202.v3IM2g62006222@ip-10-146-233-104.ec2.internal> Date: Tue, 18 Apr 2017 22:02:42 +0000 From: "anujphadke (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada , Alex Behm Reply-To: aphadke@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5145=3A_Do_not_constant_fold_null_in_CastExprs=0A?= X-Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 X-Gerrit-ChangeURL: X-Gerrit-Commit: 02f5e5d42a7ebd5345acf5791f72dd42a32446a8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 22:02:49 -0000 anujphadke has posted comments on this change. Change subject: IMPALA-5145: Do not constant fold null in CastExprs ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6663/3/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java: Line 55: // cast-to-types and that can lead to query failures, e.x., CTAS > e.g. e.g. http://gerrit.cloudera.org:8080/#/c/6663/1/testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test File testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test: Line 187: # IMPALA-5145: Do not constant fold null in CastExprs > Yes, Moving the test here and it does not catch the issue(tried it with and Yes, Moved* the test here and it does not catch the issue(tried it with and without the new change). -- To view, visit http://gerrit.cloudera.org:8080/6663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes