Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C9240200C5A for ; Tue, 18 Apr 2017 21:10:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C79AF160BA1; Tue, 18 Apr 2017 19:10:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1A80A160B87 for ; Tue, 18 Apr 2017 21:10:55 +0200 (CEST) Received: (qmail 26490 invoked by uid 500); 18 Apr 2017 19:10:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 26479 invoked by uid 99); 18 Apr 2017 19:10:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 19:10:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B44D5C0DFC for ; Tue, 18 Apr 2017 19:10:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BNo61218139C for ; Tue, 18 Apr 2017 19:10:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 882B55F39D for ; Tue, 18 Apr 2017 19:10:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3IJApH4031605; Tue, 18 Apr 2017 19:10:51 GMT Message-Id: <201704181910.v3IJApH4031605@ip-10-146-233-104.ec2.internal> Date: Tue, 18 Apr 2017 19:10:51 +0000 From: "Dan Hecht (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Allow_BlockingQueue_and_ThreadPool_to_accept_rvalue_args=0A?= X-Gerrit-Change-Id: I1791870576cb269e86495034f92555de48f92f10 X-Gerrit-ChangeURL: X-Gerrit-Commit: 36d9086af215d5efd6bbdfa34243e2e4d5e65eaf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 19:10:57 -0000 Dan Hecht has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6442/3/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: PS3, Line 134: Rvalues are moved into the queue, lvalues are : /// copied > Yes, it does. The same comment is on line 108-109. ah missed that since it's in a different ordering with the explanation of return values. this is fine. -- To view, visit http://gerrit.cloudera.org:8080/6442 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1791870576cb269e86495034f92555de48f92f10 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes