Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0CCB5200C5A for ; Tue, 18 Apr 2017 18:10:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0B5AD160BA1; Tue, 18 Apr 2017 16:10:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 52058160B90 for ; Tue, 18 Apr 2017 18:10:42 +0200 (CEST) Received: (qmail 34943 invoked by uid 500); 18 Apr 2017 16:10:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 34931 invoked by uid 99); 18 Apr 2017 16:10:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 16:10:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 658CA1896EB for ; Tue, 18 Apr 2017 16:10:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LMW-EesKVtEj for ; Tue, 18 Apr 2017 16:10:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 25ECC5FDCB for ; Tue, 18 Apr 2017 16:10:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3IGAbfF025788; Tue, 18 Apr 2017 16:10:37 GMT Message-Id: <201704181610.v3IGAbfF025788@ip-10-146-233-104.ec2.internal> Date: Tue, 18 Apr 2017 16:10:37 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Marcel Kornacker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3748=3A_minimum_buffer_requirements_in_planner=0A?= X-Gerrit-Change-Id: I1e358182bcf2bc5fe5c73883eb97878735b12d37 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4500d32d67f1d08277f17210cf1b92dc297f9f83 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 18 Apr 2017 16:10:43 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: minimum buffer requirements in planner ...................................................................... Patch Set 17: Code-Review+2 (3 comments) Rebase http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java File fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java: Line 126: Preconditions.checkState(sinkProfile.getMemEstimateBytes() >= 0); > this is already done in finalize() Thanks for catching this, didn't finish moving it. This actually masked a bug where we didn't compute resource profiles for build sinks when generating the parallel plans. http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: Line 151: * Finalize plan tree and create stream sink, if needed. > update comment Done http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: Line 621: * Compute resources consumed when executing this PlanNode, initializing > i'd simply mention the member var explicitly Done -- To view, visit http://gerrit.cloudera.org:8080/5847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e358182bcf2bc5fe5c73883eb97878735b12d37 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes