Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AD2D6200C6B for ; Tue, 18 Apr 2017 00:51:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ABCFE160BAE; Mon, 17 Apr 2017 22:51:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2A86160BAB for ; Tue, 18 Apr 2017 00:51:26 +0200 (CEST) Received: (qmail 75061 invoked by uid 500); 17 Apr 2017 22:51:26 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75045 invoked by uid 99); 17 Apr 2017 22:51:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Apr 2017 22:51:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 93E7B18FCDC for ; Mon, 17 Apr 2017 22:51:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id sEQpeNI7kvde for ; Mon, 17 Apr 2017 22:51:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CBFFD5F29C for ; Mon, 17 Apr 2017 22:51:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3HMpOgf007326; Mon, 17 Apr 2017 22:51:24 GMT Message-Id: <201704172251.v3HMpOgf007326@ip-10-146-233-104.ec2.internal> Date: Mon, 17 Apr 2017 22:51:24 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada , anujphadke , Matthew Jacobs Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2800=3A_make_memory_maintenance_less_aggressive=0A?= X-Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 X-Gerrit-ChangeURL: X-Gerrit-Commit: 739487cea5559a6bf1027f4900f851799e6e7f4b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 17 Apr 2017 22:51:27 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive ...................................................................... Patch Set 4: As we talked about in person, it'd be good to figure out whether the GcTcmalloc() is coming into play. Also, if we do need to keep this code, it seems like the rate of 256MB / 10 seconds is too slow to be meaningful (1.5 hours to release 128 GB). So it seems we should either remove this altogether if it's not needed, or speed it up if it is. -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: No