Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B2B8200C65 for ; Sat, 15 Apr 2017 00:05:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 79C1E160BA3; Fri, 14 Apr 2017 22:05:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C17FE160B8C for ; Sat, 15 Apr 2017 00:05:38 +0200 (CEST) Received: (qmail 64004 invoked by uid 500); 14 Apr 2017 22:05:38 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 63992 invoked by uid 99); 14 Apr 2017 22:05:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Apr 2017 22:05:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 67183183A68 for ; Fri, 14 Apr 2017 22:05:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xGmx7LX8lULF for ; Fri, 14 Apr 2017 22:05:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B8C0E5F20C for ; Fri, 14 Apr 2017 22:05:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3EM5a0Q009491; Fri, 14 Apr 2017 22:05:36 GMT Message-Id: <201704142205.v3EM5a0Q009491@ip-10-146-233-104.ec2.internal> Date: Fri, 14 Apr 2017 22:05:36 +0000 From: "John Russell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar , Lars Volker Reply-To: jrussell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2924=3A_=5BDOCS=5D_Add_docs_for_HDFS_cache-related_hints=0A?= X-Gerrit-Change-Id: I7284dd45c8173eef104ebd32789429e8c16c7bf2 X-Gerrit-ChangeURL: X-Gerrit-Commit: cdfa3bd932eea00267a4af8b53043038b9ea9c73 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 14 Apr 2017 22:05:39 -0000 John Russell has posted comments on this change. Change subject: IMPALA-2924: [DOCS] Add docs for HDFS cache-related hints ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6631/2/docs/topics/impala_hints.xml File docs/topics/impala_hints.xml: PS2, Line 174: -cached > I would remove the "-cached" suffix, it's really about HDFS blocks in gener Done Line 194: that are cached using the HDFS caching feature. > same here, it also has effects on non-cached blocks. Done -- To view, visit http://gerrit.cloudera.org:8080/6631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7284dd45c8173eef104ebd32789429e8c16c7bf2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes