Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B3A3F200C64 for ; Fri, 14 Apr 2017 00:53:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B2481160BA7; Thu, 13 Apr 2017 22:53:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 05949160B98 for ; Fri, 14 Apr 2017 00:53:24 +0200 (CEST) Received: (qmail 95350 invoked by uid 500); 13 Apr 2017 22:53:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 95337 invoked by uid 99); 13 Apr 2017 22:53:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 22:53:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A11551A0328 for ; Thu, 13 Apr 2017 22:53:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id pRVyFVGF2w11 for ; Thu, 13 Apr 2017 22:53:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 54DAB5F65C for ; Thu, 13 Apr 2017 22:53:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3DMrL8P019798; Thu, 13 Apr 2017 22:53:21 GMT Message-Id: <201704132253.v3DMrL8P019798@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Apr 2017 22:53:21 +0000 From: "Dan Hecht (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5172=3A_Buffer_overrun_for_Snappy_decompression=0A?= X-Gerrit-Change-Id: I45b75f61e8c0ae85f9add5b13ac2b161a803d2ba X-Gerrit-ChangeURL: X-Gerrit-Commit: a63596cafc820cdf4dd6c87ccd1ff6eefdf321c9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 13 Apr 2017 22:53:25 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5172: Buffer overrun for Snappy decompression ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6625/2/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 146: it'd be good to add a short comment explaining what this test case does. PS2, Line 147: LimitedBuffer maybe TruncatedOutput would be clearer? -- To view, visit http://gerrit.cloudera.org:8080/6625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b75f61e8c0ae85f9add5b13ac2b161a803d2ba Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes