Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E67E6200C55 for ; Thu, 13 Apr 2017 23:46:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3464160B98; Thu, 13 Apr 2017 21:46:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37999160B89 for ; Thu, 13 Apr 2017 23:46:16 +0200 (CEST) Received: (qmail 85548 invoked by uid 500); 13 Apr 2017 21:46:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85537 invoked by uid 99); 13 Apr 2017 21:46:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 21:46:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7B13CCCE57 for ; Thu, 13 Apr 2017 21:46:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id X5hFs-nXuG8U for ; Thu, 13 Apr 2017 21:46:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C034B5FC7E for ; Thu, 13 Apr 2017 21:46:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3DLkCo6015658; Thu, 13 Apr 2017 21:46:12 GMT Message-Id: <201704132146.v3DLkCo6015658@ip-10-146-233-104.ec2.internal> Date: Thu, 13 Apr 2017 21:46:12 +0000 From: "anujphadke (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: anujphadke Reply-To: aphadke@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2800=3A_make_memory_maintenance_less_aggressive=0A?= X-Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 X-Gerrit-ChangeURL: X-Gerrit-Commit: 76a89630679dfaaa562efd6ea929fea339ec1f0e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 13 Apr 2017 21:46:17 -0000 anujphadke has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6626/2/be/src/common/init.cc File be/src/common/init.cc: Line 95: static const float TCMALLOC_MAX_FREE_MEMORY_FRACTION = 0.1f; Is this reduction empirically determined? -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes