Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 76955200C54 for ; Wed, 12 Apr 2017 20:13:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7531F160B95; Wed, 12 Apr 2017 18:13:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BCFED160B85 for ; Wed, 12 Apr 2017 20:13:33 +0200 (CEST) Received: (qmail 60238 invoked by uid 500); 12 Apr 2017 18:13:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 60227 invoked by uid 99); 12 Apr 2017 18:13:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Apr 2017 18:13:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5FDF71857B9 for ; Wed, 12 Apr 2017 18:13:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QVW3sLtz_ABR for ; Wed, 12 Apr 2017 18:13:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 007765F642 for ; Wed, 12 Apr 2017 18:13:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3CIDTr0019822; Wed, 12 Apr 2017 18:13:29 GMT Message-Id: <201704121813.v3CIDTr0019822@ip-10-146-233-104.ec2.internal> Date: Wed, 12 Apr 2017 18:13:29 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5073=3A_Part_1=3A_add_option_to_use_mmap=28=29_for_buffer_pool=0A?= X-Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 X-Gerrit-ChangeURL: X-Gerrit-Commit: fbae69847e5cb14c9c2b47378cc9a3f248156b4c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 12 Apr 2017 18:13:34 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5073: Part 1: add option to use mmap() for buffer pool ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6474/8/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: Line 54: RETURN_IF_ERROR(AllocateViaMMap(len, &buffer_mem)); I added an option to enable/disable this path and disabled it by default - I don't have enough confidence right now that bypassing TCMalloc will have no undesirable side-effects. Getting this in will allow us to do experiments and defer the decision to turn it on. http://gerrit.cloudera.org:8080/#/c/6474/8/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: PS8, Line 161: TOTAL_ALLOCATED > how about SYSTEM_ALLOCATED? Done PS8, Line 165: TOTAL_RESERVED > maybe just RESERVED, but I don't feel too strongly. Done -- To view, visit http://gerrit.cloudera.org:8080/6474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes