Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E32B200C53 for ; Tue, 11 Apr 2017 19:35:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0CBEF160B9B; Tue, 11 Apr 2017 17:35:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 51CEE160B7D for ; Tue, 11 Apr 2017 19:35:06 +0200 (CEST) Received: (qmail 51908 invoked by uid 500); 11 Apr 2017 17:35:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 51897 invoked by uid 99); 11 Apr 2017 17:35:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Apr 2017 17:35:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E20F9CA8B4 for ; Tue, 11 Apr 2017 17:35:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8R9Sn8ltx4DL for ; Tue, 11 Apr 2017 17:35:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E438460D9A for ; Tue, 11 Apr 2017 17:35:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3BHZ1mx025965; Tue, 11 Apr 2017 17:35:02 GMT Message-Id: <201704111735.v3BHZ1mx025965@ip-10-146-233-104.ec2.internal> Date: Tue, 11 Apr 2017 17:35:01 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5073=3A_Use_mmap=28=29_instead_of_malloc=28=29_for_buffer_pool=0A?= X-Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 53ddc4d5feddacd56129902b0a2b913f2cf840e2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 11 Apr 2017 17:35:07 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5073: Use mmap() instead of malloc() for buffer pool ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6474/7/be/src/runtime/bufferpool/system-allocator.cc File be/src/runtime/bufferpool/system-allocator.cc: Line 81: munmap(mem, fixup); > Yeah I couldn't find any way to mmap aligned memory (aside from actually sp Regarding not calling from the system too often -- didn't you have to make adjustments to the scavenging path for that? If it turns out we do need to optimize this path, maybe easiest to amortize the cost by allocating multiple buffers at a time when memory usage is ramping back up. -- To view, visit http://gerrit.cloudera.org:8080/6474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes