Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B57A2200C60 for ; Mon, 10 Apr 2017 05:09:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B4290160BA6; Mon, 10 Apr 2017 03:09:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 08115160BA4 for ; Mon, 10 Apr 2017 05:09:52 +0200 (CEST) Received: (qmail 65242 invoked by uid 500); 10 Apr 2017 03:09:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 65231 invoked by uid 99); 10 Apr 2017 03:09:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Apr 2017 03:09:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9A1DB1A0907 for ; Mon, 10 Apr 2017 03:09:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MefADwVNkH6i for ; Mon, 10 Apr 2017 03:09:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BF2DB5FBB8 for ; Mon, 10 Apr 2017 03:09:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v3A39oHG027120; Mon, 10 Apr 2017 03:09:50 GMT Message-Id: <201704100309.v3A39oHG027120@ip-10-146-233-104.ec2.internal> Date: Mon, 10 Apr 2017 03:09:50 +0000 From: "Michael Ho (Code Review)" To: Attila Jeges , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Tim Armstrong Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3079=3A_Fix_sequence_file_writer=0A?= X-Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 X-Gerrit-ChangeURL: X-Gerrit-Commit: f1dbc3420da0d08028f0d8967b6591697a91b65c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 10 Apr 2017 03:09:53 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer ...................................................................... Patch Set 6: (2 comments) I think we should support writing sequence file. This change have fixed some bugs to get the sequence file writer to work but it's unclear to me if the existing tests have enough coverage. May help to think through the testing first before moving it out of the flag. http://gerrit.cloudera.org:8080/#/c/6107/6/be/src/exec/read-write-util.h File be/src/exec/read-write-util.h: PS6, Line 247: DCHECK(val < -112); nit: DCHECK_LT(val, -112); PS6, Line 258: DCHECK(val > 127); nit: DCHECK_GT(val, 127); -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes