Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3354200C5D for ; Fri, 7 Apr 2017 18:34:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F1ADF160BA7; Fri, 7 Apr 2017 16:34:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 442DD160BA5 for ; Fri, 7 Apr 2017 18:34:38 +0200 (CEST) Received: (qmail 54801 invoked by uid 500); 7 Apr 2017 16:34:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 54279 invoked by uid 99); 7 Apr 2017 16:34:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 16:34:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F20811A051E for ; Fri, 7 Apr 2017 16:34:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XB_LmdMAVYey for ; Fri, 7 Apr 2017 16:34:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 145215F27E for ; Fri, 7 Apr 2017 16:34:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v37GYXfS024157; Fri, 7 Apr 2017 16:34:33 GMT Message-Id: <201704071634.v37GYXfS024157@ip-10-146-233-104.ec2.internal> Date: Fri, 7 Apr 2017 16:34:33 +0000 From: "David Knupp (Code Review)" To: Taras Bobrovytsky , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Tim Armstrong , Lars Volker Reply-To: dknupp@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5181=3A_Extract_PYPI_metadata_from_a_webpage=0A?= X-Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de X-Gerrit-ChangeURL: X-Gerrit-Commit: 9706f4765bb0a475e53bf5b2bb85cfb2ca1fe9d5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 07 Apr 2017 16:34:39 -0000 David Knupp has posted comments on this change. Change subject: IMPALA-5181: Extract PYPI metadata from a webpage ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6579/1/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: Line 74: REQUIRED_PKG_TYPE = 'sdist' # Wheel archives are not supported. Perhaps a nit, but if we're considering REQUIRED_PKG_TYPE to be a "constant," I think I'd prefer to see it at the top of the file, rather than declared within this function. -- To view, visit http://gerrit.cloudera.org:8080/6579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3845a0d5f568d4352e3cc4883596736974fd7de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes