Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96B6B200C5D for ; Fri, 7 Apr 2017 18:10:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 955A9160B97; Fri, 7 Apr 2017 16:10:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DC102160B93 for ; Fri, 7 Apr 2017 18:10:06 +0200 (CEST) Received: (qmail 85038 invoked by uid 500); 7 Apr 2017 16:10:06 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85026 invoked by uid 99); 7 Apr 2017 16:10:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 16:10:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6EDE2189BFA for ; Fri, 7 Apr 2017 16:10:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Fab5j4mRWV5m for ; Fri, 7 Apr 2017 16:10:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 520485FC72 for ; Fri, 7 Apr 2017 16:10:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v37GA2e5023609; Fri, 7 Apr 2017 16:10:02 GMT Message-Id: <201704071610.v37GA2e5023609@ip-10-146-233-104.ec2.internal> Date: Fri, 7 Apr 2017 16:10:02 +0000 From: "Michael Brown (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3794=3A_Workaround_for_Breakpad_ID_conflicts=0A?= X-Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862 X-Gerrit-ChangeURL: X-Gerrit-Commit: 54aa41f4e3fedf38e8405f9c5f5a5d11298c5b82 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 07 Apr 2017 16:10:07 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-3794: Workaround for Breakpad ID conflicts ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6588/2/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS2, Line 156: self.assert_num_logfile_entries(1) : # IMPALA-3794 / Breakpad-681: Weak minidump ID generation can lead to name conflicts, : # so that one process overwrites the minidump of others. See IMPALA-3794 for more : # information. : # TODO: Change this here and elsewhere in this file to expect 'cluster_size' minidumps : # once Breakpad-681 has been fixed. : assert self.count_minidumps('impalad') >= 1 : assert self.count_minidumps('statestored') == 1 : assert self.count_minidumps('catalogd') == 1 Any interest in making this a private method that is called L183, L201, etc.? You reduce maintenance, and now your L157-161 note applies in the one place it matters. -- To view, visit http://gerrit.cloudera.org:8080/6588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes