Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3F178200C48 for ; Thu, 6 Apr 2017 23:57:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3D9E9160B91; Thu, 6 Apr 2017 21:57:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 848F2160B81 for ; Thu, 6 Apr 2017 23:57:40 +0200 (CEST) Received: (qmail 61667 invoked by uid 500); 6 Apr 2017 21:57:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 61656 invoked by uid 99); 6 Apr 2017 21:57:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 21:57:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3FAE2C0F5B for ; Thu, 6 Apr 2017 21:57:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8dx0YCZmh5-9 for ; Thu, 6 Apr 2017 21:57:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 73F5F5F1A1 for ; Thu, 6 Apr 2017 21:57:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v36LvaYv009622; Thu, 6 Apr 2017 21:57:36 GMT Message-Id: <201704062157.v36LvaYv009622@ip-10-146-233-104.ec2.internal> Date: Thu, 6 Apr 2017 21:57:35 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5124=3A_add_tests_for_scratch_read_errors=0A?= X-Gerrit-Change-Id: I3f2b93588dd47f70a4863ecad3b5556c3634ccb4 X-Gerrit-ChangeURL: X-Gerrit-Commit: aa02401839d05ac7f0d8749ae30733495a1df23d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 06 Apr 2017 21:57:41 -0000 Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5124: add tests for scratch read errors ...................................................................... IMPALA-5124: add tests for scratch read errors Adds tests for read errors from permissions (i.e. open() fails), corrupt data (integrity check fails) and truncated files (read() fails). Fixes a couple of bugs: * Truncated reads were not detected in TmpFilemgr * IoMgr buffers weren't returned on error paths (this isn't a true leak but results in DCHECKs being hit). Change-Id: I3f2b93588dd47f70a4863ecad3b5556c3634ccb4 --- M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/tmp-file-mgr.cc M common/thrift/generate_error_codes.py 3 files changed, 109 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/6562/2 -- To view, visit http://gerrit.cloudera.org:8080/6562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f2b93588dd47f70a4863ecad3b5556c3634ccb4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong