Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B59B200C48 for ; Thu, 6 Apr 2017 23:36:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 99EB5160B91; Thu, 6 Apr 2017 21:36:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1F2A160B81 for ; Thu, 6 Apr 2017 23:36:48 +0200 (CEST) Received: (qmail 10163 invoked by uid 500); 6 Apr 2017 21:36:48 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 10152 invoked by uid 99); 6 Apr 2017 21:36:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Apr 2017 21:36:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 72D16C07F5 for ; Thu, 6 Apr 2017 21:36:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tt006AuvLscC for ; Thu, 6 Apr 2017 21:36:46 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4201B5F39D for ; Thu, 6 Apr 2017 21:36:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v36LaiGJ008496; Thu, 6 Apr 2017 21:36:44 GMT Message-Id: <201704062136.v36LaiGJ008496@ip-10-146-233-104.ec2.internal> Date: Thu, 6 Apr 2017 21:36:44 +0000 From: "Tim Armstrong (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5173=3A_crash_with_hash_join_feeding_directly_into_nlj=0A?= X-Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3a0424321a3df7872ed541de51adf9887ce94dd8 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 06 Apr 2017 21:36:49 -0000 Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6568 to look at the new patch set (#3). Change subject: IMPALA-5173: crash with hash join feeding directly into nlj ...................................................................... IMPALA-5173: crash with hash join feeding directly into nlj The background for this bug is that we can't transfer ownership of BufferdBlockMgr::Blocks that are attached to RowBatches. The NestedLoopJoinNode accumulates row batches on its right side and tries to take ownership of the memory, which doesn't work as expected in this case. The fix is to copy the data when we encounter one of these (likely very rare) cases. Testing: Added a regression test that produces a crash before the fix and succeeds after the fix. Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 --- M be/src/exec/nested-loop-join-builder.cc M testdata/workloads/functional-query/queries/QueryTest/spilling.test 2 files changed, 44 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/6568/3 -- To view, visit http://gerrit.cloudera.org:8080/6568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c04952e591d17e5ff7e994884be4c4c899ae192 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong