Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F581200C4D for ; Wed, 5 Apr 2017 20:07:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0DD84160B94; Wed, 5 Apr 2017 18:07:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 55085160B76 for ; Wed, 5 Apr 2017 20:07:05 +0200 (CEST) Received: (qmail 32150 invoked by uid 500); 5 Apr 2017 18:07:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 32139 invoked by uid 99); 5 Apr 2017 18:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 18:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E085AC0115 for ; Wed, 5 Apr 2017 18:07:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Jnt1JeL9ldBi for ; Wed, 5 Apr 2017 18:07:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6DC675F2FE for ; Wed, 5 Apr 2017 18:07:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v35I70J9008591; Wed, 5 Apr 2017 18:07:00 GMT Message-Id: <201704051807.v35I70J9008591@ip-10-146-233-104.ec2.internal> Date: Wed, 5 Apr 2017 18:07:00 +0000 From: "Michael Brown (Code Review)" To: Laurel Hale , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5140=3A_improve_docs_building_guidelines=0A?= X-Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f X-Gerrit-ChangeURL: X-Gerrit-Commit: 5e0a35d5d04306769e0eef334ef80cf27efd6857 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 05 Apr 2017 18:07:06 -0000 Hello Laurel Hale, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6512 to look at the new patch set (#8). Change subject: IMPALA-5140: improve docs building guidelines ...................................................................... IMPALA-5140: improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will automatically render the document inline at places like: https://github.com/apache/incubator-impala/tree/master/docs under the directory listing. Fix existing markdown which wasn't always rendering properly. Remove unneeded HTML and backslashes. Add a mention of make, and add one troubleshooting tip. Wrap most lines at 90 chars. This does not change how Github renders the markdown, and it makes reading the source easier as well. Explain how to get dita into PATH. Emphasize make and remove some of the dita advanced usage. Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f --- A docs/README.md D docs/generatingImpalaDoc.md 2 files changed, 201 insertions(+), 73 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/6512/8 -- To view, visit http://gerrit.cloudera.org:8080/6512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ae79ecd346045697fe225140ee9a317c5a337f Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown