Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A79A1200C4D for ; Wed, 5 Apr 2017 09:58:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A626B160B94; Wed, 5 Apr 2017 07:58:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EDE59160B91 for ; Wed, 5 Apr 2017 09:58:28 +0200 (CEST) Received: (qmail 7263 invoked by uid 500); 5 Apr 2017 07:58:28 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 7245 invoked by uid 99); 5 Apr 2017 07:58:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 07:58:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 896E7CCE43 for ; Wed, 5 Apr 2017 07:58:27 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LOAVwoZ6aQGE for ; Wed, 5 Apr 2017 07:58:27 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 66E2B5F1E9 for ; Wed, 5 Apr 2017 07:58:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v357wOWt003748; Wed, 5 Apr 2017 07:58:24 GMT Message-Id: <201704050758.v357wOWt003748@ip-10-146-233-104.ec2.internal> Date: Wed, 5 Apr 2017 07:58:24 +0000 From: "Lars Volker (Code Review)" To: Jakub Kukul , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1726=3A_Treat_parquet_ENUMs_as_STRINGs_when_creating_tables=2E=0A?= X-Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475 X-Gerrit-ChangeURL: X-Gerrit-Commit: f042b69e41a6a5ac362f4929c7ac39192e614485 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 05 Apr 2017 07:58:29 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables. ...................................................................... Patch Set 1: (1 comment) Thank you for working on this. Have you already thought about how we could test this? You can have a look at testdata/workloads/functional-query/queries/QueryTest/create-table-like-file.test, but I'm unsure whether we have a parquet file with an ENUM in our testdata already. Let me know if you get stuck there and we can figure out how to add one. http://gerrit.cloudera.org:8080/#/c/6550/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-1726 IMPALA-2525? -- To view, visit http://gerrit.cloudera.org:8080/6550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a2e20c3ab83eb3fac422c3b33c117856fec475 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jakub Kukul Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes