Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC8F8200C5A for ; Tue, 4 Apr 2017 00:48:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CB0AF160B9C; Mon, 3 Apr 2017 22:48:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E517160B8F for ; Tue, 4 Apr 2017 00:48:10 +0200 (CEST) Received: (qmail 96418 invoked by uid 500); 3 Apr 2017 22:48:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 96391 invoked by uid 99); 3 Apr 2017 22:48:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 22:48:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AEBCCC05B2 for ; Mon, 3 Apr 2017 22:48:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jpkUm-xwdHVu for ; Mon, 3 Apr 2017 22:48:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BF8FF5FBB9 for ; Mon, 3 Apr 2017 22:48:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v33Mm6KC006564; Mon, 3 Apr 2017 22:48:06 GMT Message-Id: <201704032248.v33Mm6KC006564@ip-10-146-233-104.ec2.internal> Date: Mon, 3 Apr 2017 22:48:06 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4701=3A_make_distcc_work_reliably_with_clang=0A?= X-Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 X-Gerrit-ChangeURL: X-Gerrit-Commit: fd1b40d5719745200dcb41ac248f1ab7042c1164 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 03 Apr 2017 22:48:12 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4701: make distcc work reliably with clang ...................................................................... IMPALA-4701: make distcc work reliably with clang The previous compiler-switching method in distcc had some problems: * It duplicated logic from CMakeLists.txt in choosing flags to pass to clang * In order to switch to ASAN, you needed to remember to change distcc settings. * The wrapper script approach interacted badly with ccache - GCC and Clang-generated artifacts would be treated as equivalent by ccache, meaning that if you accidentally build with the wrong compiler setting and the artifacts got into the cache you needed to clear ccache. Instead of using environment variables to set the compiler, we now pass the compiler as an argument to distcc.sh and set things up in CMakeLists.txt the same way as ccache. Switching to/from clang builds now requires no extra step (aside from cleaning out the cmake-generated files with clean.sh). Also changes the name of the config file Testing: Tested switching between debug and asan builds locally. Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Reviewed-on: http://gerrit.cloudera.org:8080/6493 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/CMakeLists.txt M bin/clean.sh M bin/distcc/README.md M bin/distcc/distcc.sh M bin/distcc/distcc_env.sh 5 files changed, 47 insertions(+), 54 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199b245fb14b6c3484b66339a7d4b37d74755af7 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong