Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C5753200C5A for ; Tue, 4 Apr 2017 00:21:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C3F38160B9C; Mon, 3 Apr 2017 22:21:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15F31160B8F for ; Tue, 4 Apr 2017 00:21:10 +0200 (CEST) Received: (qmail 41575 invoked by uid 500); 3 Apr 2017 22:21:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 41564 invoked by uid 99); 3 Apr 2017 22:21:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 22:21:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ABD22180673 for ; Mon, 3 Apr 2017 22:21:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YF2KySVs0BjU for ; Mon, 3 Apr 2017 22:21:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6D8F75FBFA for ; Mon, 3 Apr 2017 22:21:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v33ML7Jh005692; Mon, 3 Apr 2017 22:21:08 GMT Message-Id: <201704032221.v33ML7Jh005692@ip-10-146-233-104.ec2.internal> Date: Mon, 3 Apr 2017 22:21:07 +0000 From: "Tim Armstrong (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4893=3A_Efficiently_update_the_rows_read_counter_for_sequence_file=0A?= X-Gerrit-Change-Id: Ie42c97a36e46172884cc497aa645036c2c11f541 X-Gerrit-ChangeURL: X-Gerrit-Commit: 383ffa9aa977481f2285236bcf5869ba35918baf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 03 Apr 2017 22:21:12 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks good to me. Did you run the modified scanner tests for all the exhaustive file formats? I'll run that myself before merging. http://gerrit.cloudera.org:8080/#/c/6522/2/be/src/exec/hdfs-sequence-scanner.cc File be/src/exec/hdfs-sequence-scanner.cc: Line 345: if (stream_->eof()) { We put simple "if" statements on one like (https://google.github.io/styleguide/cppguide.html#Conditionals) if (stream_->eof()) break; -- To view, visit http://gerrit.cloudera.org:8080/6522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie42c97a36e46172884cc497aa645036c2c11f541 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes