Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 75B79200C3C for ; Mon, 3 Apr 2017 18:33:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 74616160B8F; Mon, 3 Apr 2017 16:33:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B292F160B8D for ; Mon, 3 Apr 2017 18:33:04 +0200 (CEST) Received: (qmail 23748 invoked by uid 500); 3 Apr 2017 16:33:03 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 23736 invoked by uid 99); 3 Apr 2017 16:33:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Apr 2017 16:33:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DF9FF1805D6 for ; Mon, 3 Apr 2017 16:33:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DwXR-IJtnjCP for ; Mon, 3 Apr 2017 16:33:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E00725FCE8 for ; Mon, 3 Apr 2017 16:33:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v33GX0vO026584; Mon, 3 Apr 2017 16:33:00 GMT Message-Id: <201704031633.v33GX0vO026584@ip-10-146-233-104.ec2.internal> Date: Mon, 3 Apr 2017 16:33:00 +0000 From: "Tim Armstrong (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5031=3A_Remove_undefined_behavior=3A_left_shift_into_the_sign_bit=0A?= X-Gerrit-Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d X-Gerrit-ChangeURL: X-Gerrit-Commit: 5857b9138b1e8f0a316ef6c8a4378dc1d258ac32 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 03 Apr 2017 16:33:05 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior: left shift into the sign bit ...................................................................... Patch Set 1: (2 comments) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/6528/1/be/src/exprs/bit-byte-functions-ir.cc File be/src/exprs/bit-byte-functions-ir.cc: Line 151: return (static_cast>(v) << shift) > In ExprTest.BitByteBuiltins: There's an implicit conversion back to the signed return type. I think it would be clearer if that was explicit. Line 170: return static_cast>(v) << shift; > In ExprTest.BitByteBuiltins: Same here -- To view, visit http://gerrit.cloudera.org:8080/6528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes