impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure
Date Fri, 28 Apr 2017 17:35:09 GMT
Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6757

Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure
......................................................................

IMPALA-5246: UDF's Close() should handle Expr's preparation failure

UDF may fail to initialize due low memory limit or
other reasons In which case, its Prepare() function may
not have been called and its thread local state may not be
initialized.

The Close() functions of some of the built-in and test-udf
made the wrong assumption that the thread local states are
always initialized. This may lead to de-referencing null
pointer in Close(). This change fixes this issue by
checking the thread local state is not null and returns
early if so.

Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c
---
M be/src/exprs/case-expr.cc
M be/src/exprs/math-functions-ir.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/timestamp-functions.cc
M be/src/exprs/utility-functions.cc
M be/src/testutil/test-udfs.cc
6 files changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/6757/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message