impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries
Date Tue, 25 Apr 2017 21:42:01 GMT
Zach Amsden has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6726

Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries
......................................................................

IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

When dictionaries are present we can pre-evaluate conjuncts
against the dictionary values and simply look up the result.

Status of this diff:

Subclassing the BaseScalarColumnReader into a separate
FilteredColumnReader is rather spectacularly disastrous in its
interplay with the templatized ScalarColumnReader implementation.
I'll just move everything into the ScalarColumnReader class and
use boolean template parameters to control the behavior.

Change-Id: I65981c89e5292086809ec1268f5a273f4c1fe054
---
M be/src/exec/hdfs-parquet-scanner-ir.cc
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-parquet-scanner.h
M be/src/exec/parquet-column-readers.cc
M be/src/exec/parquet-column-readers.h
M be/src/exec/parquet-scratch-tuple-batch.h
M be/src/util/bitmap-test.cc
M be/src/util/bitmap.h
M be/src/util/dict-encoding.h
9 files changed, 336 insertions(+), 152 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/6726/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65981c89e5292086809ec1268f5a273f4c1fe054
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message