impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5222: don't call Bits::Log2*() functions
Date Tue, 18 Apr 2017 20:13:15 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6675

Change subject: IMPALA-5222: don't call Bits::Log2*() functions
......................................................................

IMPALA-5222: don't call Bits::Log2*() functions

Some of gutil's functions are fairly inefficient. We accidentally
regressed this when switching to the new Bits::, and some of the
BufferPool code that was in flight didn't switch over.

This commit switches to calling BitUtil::Log2*() everywhere and makes
sure that those functions are all implemented in an efficient way.

Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c
---
M be/src/exec/parquet-column-readers.cc
M be/src/runtime/bufferpool/buffer-allocator.cc
M be/src/runtime/bufferpool/buffer-pool.cc
M be/src/runtime/disk-io-mgr.cc
M be/src/runtime/free-pool.h
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/dict-encoding.h
M be/src/util/hdr-histogram.cc
11 files changed, 45 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/6675/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46471590ae7cf5ccd3e44d5c31f0b06108a2a01c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message