impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5217: KuduTableSink checks null constraints incorrectly
Date Tue, 18 Apr 2017 18:31:59 GMT
Thomas Tauber-Marshall has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6670

Change subject: IMPALA-5217: KuduTableSink checks null constraints incorrectly
......................................................................

IMPALA-5217: KuduTableSink checks null constraints incorrectly

KuduTableSink uses the referenced_columns map to translate between the index into the
output exprs 'j' and the index into columns in the Kudu table 'col', but we incorrectly
use 'j' when calling into the Kudu table schema to check the nullability of columns.

Testing:
- Added e2e tests to kudu_insert.test

Change-Id: I8ed458278f135288a821570939de8ee294183df2
---
M be/src/exec/kudu-table-sink.cc
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
2 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/6670/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ed458278f135288a821570939de8ee294183df2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>

Mime
View raw message