impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5235: Initialize resourceProfile with a dummy value
Date Sat, 29 Apr 2017 03:34:15 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5235: Initialize resourceProfile_ with a dummy value
......................................................................


IMPALA-5235: Initialize resourceProfile_ with a dummy value

resourceProfile_ is initialized to NULL and gets set later while
finalizing the plan fragment. resourceProfile_ is accessed in
createHashJoinFragment before it gets set. Accessing it before
throws a NullPointerException. This change initializes it with a dummy
value instead of null to avoid this.
This code path gets executed only with log_level=3

Change-Id: I02de2ca1f627d7f61921840722661a5323e91579
Reviewed-on: http://gerrit.cloudera.org:8080/6750
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6750
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02de2ca1f627d7f61921840722661a5323e91579
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message