impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Jeges (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5261: Heap use-after-free in HdfsSequenceTableWriter
Date Fri, 28 Apr 2017 21:42:38 GMT
Attila Jeges has posted comments on this change.

Change subject: IMPALA-5261: Heap use-after-free in HdfsSequenceTableWriter
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > I assumed you have verified the fix with ASAN build, right ?

Yes, added testing details to the commit message.

http://gerrit.cloudera.org:8080/#/c/6762/1/be/src/exec/hdfs-sequence-table-writer.cc
File be/src/exec/hdfs-sequence-table-writer.cc:

Line 306:     value_length = text.size();
> DCHECK_EQ(value_length, row_buf_.Size());
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id339247f892710529d8ad56dd1e98eadbf32900b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message