impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded
Date Fri, 28 Apr 2017 21:35:34 GMT
Hello Michael Ho, Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6761

to look at the new patch set (#3).

Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded
......................................................................

IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded

We need to check for AllocateLocal() returning NULL. CopyFrom() takes
care of that for us.  Also adjust a few other places in the code base
that didn't have the check.

The new test reproduces the crash, but in order to get this test file to
execute, I had to move the xfail to be a function decorator. Apparently
xfail as a statement causes the test to not run at all. We should run
all of these queries even if they are non-determistic to at least verify
that impalad does not crash.

Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/hive-udf-call.cc
M be/src/exprs/udf-builtins-ir.cc
M be/src/udf/uda-test.cc
M be/src/udf/udf-test.cc
M be/src/udf_samples/uda-sample.cc
M testdata/workloads/functional-query/queries/QueryTest/alloc-fail-update.test
M tests/custom_cluster/test_alloc_fail.py
8 files changed, 27 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/6761/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message