impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded
Date Fri, 28 Apr 2017 21:24:34 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6761/1//COMMIT_MSG
Commit Message:

PS1, Line 10: a few other places
> Thanks for doing it. Please feel free to ignore but there are a few places 
I did the ones where we can get rid of the is_null check at the callsite. For some of them,
we still need the is_null check, so it seems clearest to not use CopyFrom() in those cases.


PS1, Line 14: marker
> I believe in python this is called a decorator.
Done


http://gerrit.cloudera.org:8080/#/c/6761/1/be/src/udf_samples/uda-sample.cc
File be/src/udf_samples/uda-sample.cc:

Line 86: void StringConcatUpdate(FunctionContext* context, const StringVal& arg1,
> until we remove the impala-udf-sample repo, we should probably keep that co
How do make changes to that?


-- 
To view, visit http://gerrit.cloudera.org:8080/6761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message