impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded
Date Fri, 28 Apr 2017 21:15:49 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6761/1//COMMIT_MSG
Commit Message:

PS1, Line 10: a few other places
Thanks for doing it. Please feel free to ignore but there are a few places in the code which
can be converted to using StringVal::CopyFrom() even though they have the check:
AggregateFunctions::ReservoirSampleFinalize(),  CastFunctions::CastToChar(), udf-builtins-ir.cc,
?


-- 
To view, visit http://gerrit.cloudera.org:8080/6761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message