impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded
Date Fri, 28 Apr 2017 21:12:24 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6761/1//COMMIT_MSG
Commit Message:

PS1, Line 14: marker
I believe in python this is called a decorator.


http://gerrit.cloudera.org:8080/#/c/6761/1/be/src/udf_samples/uda-sample.cc
File be/src/udf_samples/uda-sample.cc:

Line 86: void StringConcatUpdate(FunctionContext* context, const StringVal& arg1,
until we remove the impala-udf-sample repo, we should probably keep that code up to date as
well:
https://github.com/cloudera/impala-udf-samples/blob/master/uda-sample.cc


-- 
To view, visit http://gerrit.cloudera.org:8080/6761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafefef24479164cc4d2b99191d2de28eb8b311b6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message