impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Valencia Edna Serrao (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] Aligned ppc64le-ported native-toolchain to be consistent with upstream style Also, updated apply patches function to appropriately apply patches w.r.t host arch's
Date Thu, 27 Apr 2017 05:39:54 GMT
Valencia Edna Serrao has posted comments on this change.

Change subject: Aligned ppc64le-ported native-toolchain to be consistent with upstream style
Also, updated apply_patches function to appropriately apply patches w.r.t host arch's
......................................................................


Patch Set 1:

> > > It appears you have forgotten to squash your commits using git
 > > > rebase
 > >
 > >
 > > I ran the following commands before pushing the second patch set.
 > > git fetch asf-gerrit
 > > git rebase asf-gerrit/master
 > > and it showed my branch is up-to-date
 > >
 > > Please let me know if there is any other check I need to do.
 > 
 > Please google "git rebase squash", then squash the two patches,
 > leaving only the Change-Id in the commit message from the first
 > one.

Thanks, Jim! for guiding me on rectifying this. I have squashed all commit to one keeping
the Change-Id of the first commit. 

Please let me know if it is fine.

-- 
To view, visit http://gerrit.cloudera.org:8080/6739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9450a8df6844f45f84f4859840a9fcab1b1ca526
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Valencia Edna Serrao <vserrao@us.ibm.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Valencia Edna Serrao <vserrao@us.ibm.com>
Gerrit-HasComments: No

Mime
View raw message