impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg
Date Wed, 26 Apr 2017 15:07:39 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6724/4/be/src/testutil/test-udas.cc
File be/src/testutil/test-udas.cc:

PS4, Line 59: Intermediate
why "Intermediate"? THis validates arg and return type as well.

oh, from the next two Validate routines, I think you mean to distinguish them based on the
type of intermediate, not the types you are validating? if that's the case, this name doesn't
distinguish.


-- 
To view, visit http://gerrit.cloudera.org:8080/6724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I158303b20d1afdff23c67f3338b9c4af2ad80691
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message